Appbar MD3 Expressive improvements - #5075
Open
pawelkata wants to merge 34 commits into
Open
Conversation
added 20 commits
August 25, 2026 12:52
JKobrynski
requested changes
Aug 25, 2026
| elevation={elevation} | ||
| ref={ref} | ||
| testID={`${testID}-root-layer`} | ||
| elevation={0} |
Collaborator
There was a problem hiding this comment.
md.comp.app-bar.on-scroll.container.elevationresolves tolevel2, butelevationis pinned to0-isScrolledonly changes the container colour. Intentional?
Author
There was a problem hiding this comment.
I'm probably missing something here, but... according to MD3 guidelines here: https://m3.material.io/components/app-bars/guidelines and the Figma kit, there's no elevation in appbars -- just the color indication that content was scrolled.
Collaborator
|
@pawelkata can you resolve the comments that have been addressed? 🙏 |
adam-sajko
added a commit
to adam-sajko/react-native-paper
that referenced
this pull request
Aug 27, 2026
callstack#4934 proposes an `actions` prop API for Appbar and callstack#5075 implements it, so the children refactor here is superseded. Appbar sources, tests and snapshots go back to their state on main.
|
|
added 8 commits
August 27, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Replace the legacy compound Appbar API with a prop-driven Material 3 implementation. This adds small, flexible, and search variants; filled actions; scroll-aware colors; safe-area handling; and improved accessibility. Documentation, examples, and downstream usages are updated accordingly.
Related issue
Related issue: #4934
Also based on comments on Appbar from here: #4949 (comment) .
Caveats
The search bar is dropped in verbatim as it needs a separate pool of work to properly handle the "search" variant. Deliberately skipped any animations related work at this stage due to lack of testing device and the PR already being quite big. Can be tackled at a later stage.
NOTE: The PR drops support for the bottom app bar variant, which is now - according to the official docs - part of the
Toolbars.Test plan
yarn test src/components/__tests__/Appbar.yarn lintandyarn typecheck.